clarify -U option in groupadd help output #1389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks! Can you please squash the commits? |
Align wording with groupmod to reduce ambiguity in -U option description.
ashgit23
force-pushed
the
clarify-groupadd-U-help
branch
from
7d22424 to
6e60f0e
Compare
Contributor
Author
|
Thank you for the feedback ! Commits squashed as requested. PR is now a single commit with updated message. |
alejandro-colomar
approved these changes
Nov 18, 2025
Collaborator
alejandro-colomar
left a comment
alejandro-colomar
left a comment
There was a problem hiding this comment.
LGTM. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the help text for the -U option in groupadd to improve clarity and reduce ambiguity.
Old text:
-U, --users USERS list of user members of this group
New text:
-U, --users USERS list of users to assign to the group
The previous phrasing could be misinterpreted as querying existing group members. The updated version makes it clear that this option is used to assign users when creating a new group.
This change affects only the English help output in src/groupadd.c. No functional behavior is modified