src/: Fix uninitialized flags, and use const appropriately #1400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandro-colomar
force-pushed
the
flags
branch
from
6ec6f9b to
bee2990
Compare
hallyn
approved these changes
Dec 5, 2025
Member
hallyn
left a comment
hallyn
left a comment
There was a problem hiding this comment.
LGTM. Will leave it for Iker to approve and merge, in case I'm missing something.
Yeah, if they were in BSS they'd be 0/false, but these are not, so...
In all these functions, we were setting the flags to 'true' in process_flags() if the appropriate command-line flag was specified. However, they were never being defined to 'false', which should be the default value. Initialize these flags to false. Fixes: c0c9485 (2025-10-07; "src/useradd.c: chroot or prefix SELinux file context") Link: <shadow-maint#1396> Reviewed-by: Serge Hallyn <serge@hallyn.com> Cc: Iker Pedrosa <ipedrosa@redhat.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar
force-pushed
the
flags
branch
from
bee2990 to
652fa19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: c0c9485 (2025-10-07; "src/useradd.c: chroot or prefix SELinux file context")
Link: #1396
Cc: Iker Pedrosa ipedrosa@redhat.com