Skip to content

Conversation

@MMMMMYY
Copy link

@MMMMMYY MMMMMYY commented Oct 29, 2021

Hi,
This is my pull request. It uses the stylegan to generated knee MRI imgaes.
The detail sees README.md

Thanks

@MMMMMYY MMMMMYY changed the title Mengyao Ma - 45857876 - StyleGAN Mengyao Ma - 45857876 - StyleGAN-test Oct 29, 2021
@MMMMMYY MMMMMYY changed the title Mengyao Ma - 45857876 - StyleGAN-test Mengyao Ma - 45857876 - StyleGAN-pull request test Oct 29, 2021
delete the spare argument
Copy link
Collaborator

@WeiDaiwow WeiDaiwow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have both test and driver file
Nice readme file
An algorithm solves the problems
Good design and nice implementation
Nice comments
Nice description and explanation of the algorithm
Correct pull request with the description
nice visualization and plots
Dependencies included
Nice output and plots
Nice markdown
Nice reference

Suggestions:

  1. All commits happened in 4 days

@shakes76
Copy link
Owner

TF/Torch Usage

Adequate use and implementation

Good Practice (Design/Commenting)

Good spacing and comments
No Header blocks -1

Algorithm

Driver Script present
Shows Usage & Demo & Visualisation & Data usage
Module present
No Data leakage
Difficulty: Hard

Commit Log

Meaningful commit messages, could be more descriptive -1
Progressive commits used

Documentation

Good Description, but could use more comments -1
Markdown used PDF submitted

Pull Request

Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch)
Merge conflict because of the .gitignore file, can you either remove the file or revert it so I can merge? -2
Request Description could be more informative -1

@MMMMMYY
Copy link
Author

MMMMMYY commented Nov 21, 2021

sure. I will fix it.

@shakes76
Copy link
Owner

Still showing the .gitignore with conflict. Feedback was tried though, so mark awarded. Still can't merge though.

@MMMMMYY
Copy link
Author

MMMMMYY commented Nov 22, 2021

Still showing the .gitignore with conflict. Feedback was tried though, so mark awarded. Still can't merge though.

I fix that right now. could you please try again?

@shakes76 shakes76 merged commit 34f0f3c into shakes76:topic-recognition Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants