-
Notifications
You must be signed in to change notification settings - Fork 391
Mengyao Ma - 45857876 - StyleGAN-pull request test #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mengyao Ma - 45857876 - StyleGAN-pull request test #226
Conversation
upload some training function
delete the spare argument
WeiDaiwow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have both test and driver file
Nice readme file
An algorithm solves the problems
Good design and nice implementation
Nice comments
Nice description and explanation of the algorithm
Correct pull request with the description
nice visualization and plots
Dependencies included
Nice output and plots
Nice markdown
Nice reference
Suggestions:
- All commits happened in 4 days
TF/Torch UsageAdequate use and implementation Good Practice (Design/Commenting)Good spacing and comments AlgorithmDriver Script present Commit LogMeaningful commit messages, could be more descriptive -1 DocumentationGood Description, but could use more comments -1 Pull RequestSuccessful Pull Request (Working Algorithm Delivered on Time in Correct Branch) |
|
|
Still showing the .gitignore with conflict. Feedback was tried though, so mark awarded. Still can't merge though. |
I fix that right now. could you please try again? |
Hi,
This is my pull request. It uses the stylegan to generated knee MRI imgaes.
The detail sees README.md
Thanks