Skip to content

Conversation

@ShangGao-forever
Copy link

No description provided.

Copy link
Collaborator

@WeiDaiwow WeiDaiwow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pro:
Have both test and driver file
Good commits
Nice readme file
An algorithm solves the problems
Good design and nice implementation
Nice description and explanation of the algorithm
nice visualization and plots
Dependencies included
Nice output and plots
Nice Markdown
Nice reference

Con:
Not enough comments for training and testing files
No description in the pull request

@shakes76
Copy link
Owner

TF/Torch Usage

Adequate use and implementation

Good Practice (Design/Commenting)

Good spacing and comments
Header blocks

Algorithm

Driver Script present
Shows Usage & Demo & Visualisation & Data usage
Module present
No Data leakage
Difficulty: Hard

Commit Log

Meaningful commit messages, could be more descriptive -1
Progressive commits used

Documentation

Good Description and Comments
Markdown used PDF submitted

Pull Request

Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch)
No Feedback required
Request Description missing -2

@shakes76 shakes76 merged commit b895959 into shakes76:topic-recognition Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants