-
Notifications
You must be signed in to change notification settings - Fork 391
45762402_Topic recognition #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
45762402_Topic recognition #235
Conversation
…er/PatternFlow into topic-recognition
WeiDaiwow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pro:
Have both test and driver file
Good commits
Nice readme file
An algorithm solves the problems
Good design and nice implementation
Nice description and explanation of the algorithm
nice visualization and plots
Dependencies included
Nice output and plots
Nice Markdown
Nice reference
Con:
Not enough comments for training and testing files
No description in the pull request
This reverts commit 2b497a1.
TF/Torch UsageAdequate use and implementation Good Practice (Design/Commenting)Good spacing and comments AlgorithmDriver Script present Commit LogMeaningful commit messages, could be more descriptive -1 DocumentationGood Description and Comments Pull RequestSuccessful Pull Request (Working Algorithm Delivered on Time in Correct Branch) |
No description provided.