No error event on compilation error when watching#126
Conversation
|
+1 |
|
+1 |
|
+1 |
|
If you don't want to wait for this PR to be merged, you can (temporarily) add
|
|
+1 |
3 similar comments
|
+1 |
|
+1 |
|
+1 |
|
Can we please get this merged? :) |
|
@shama 🙏 |
|
+1 |
1 similar comment
|
+1 |
|
☝️ |
|
+1, please merge! |
|
+1 please @shama 🙏 |
see shama#34 (comment) and shama#126 >> With a little help of @gkiely's comment, I found the root of the problem: >> When a compilation error occurs, >> - webpack-stream emits an error event. >> - Node listens for stream error events >> - and removes the ondata handler. >> - Therefore, it stops writing data to the destination after an error event has occurred. >> To solve this issue, webpack-stream should not emit an error event on compilation error. >> At least not when watching. PR shama#126 should solve this.
|
@shama Can you at least add a volunteer as a repo owner, if you're done with this project? I've had a repeating reminder for over a month now to check if the PR has been merged. Would be much appreciated. :) |
|
It somehow looks that this package is abandoned since April. |
|
Indeed... So because there was still no response from the author after three monhts, I recently published my fork with this PR included (https://github.com/jeroennoten/webpack-stream) on NPM as |
|
@jeroennoten I've just switched to it. Thanks! |
|
+1 please transfer ownership or merge this |
|
@shama, please merge this. |
|
@shama, please merge this. Many of us in this thread are using |
|
🎉 |
This gets gulp writing to the destination after a webpack error has occurred. shama/webpack-stream#126
20 participants
No
errorevent should be emitted on a compilation error when watching, because node stops writing data after anerrorevent. See #34 (comment) for a detailed description.Instead, we can always safely emit a
compilation-errorevent. This makes sure that others are still able listen for compilation errors. Additionally, when we are not in watch mode, we do emit anerrorevent to keep the behavior the same and do not break backwards compatibility for non-watching tasks.