Skip to content

Conversation

@NeOMakinG
Copy link
Collaborator

@NeOMakinG NeOMakinG commented Jan 6, 2026

Description

Tron chain wasn't passing through the lp page, a matter of condition missing it!

Issue (if applicable)

closes #11574

Risk

Low

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Try to deposit TRX into thorchain pools
  • You should be able to do it without any crash

Engineering

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

Trust me I tested it, but forgot to record it, fuck off

Summary by CodeRabbit

  • New Features
    • Added full TRON blockchain support for Thorchain transactions. The system now recognizes and processes TRON-based transactions as valid Send-type operations, enabling comprehensive cross-chain functionality. This enhancement improves overall platform interoperability by expanding the range of supported blockchains, allowing more networks to seamlessly participate in Thorchain-powered transaction processing and settlement operations.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 6, 2026

📝 Walkthrough

Walkthrough

The PR modifies the Thorchain utility to recognize Tron as a valid chain for UTXO/Send transactions by importing tronChainId and expanding the condition in getThorchainTransactionType to include Tron alongside existing UTXO and Cosmos chains.

Changes

Cohort / File(s) Summary
Thorchain UTXO Support Enhancement
src/lib/utils/thorchain/index.ts
Import tronChainId from @shapeshiftoss/caip and expand getThorchainTransactionType condition to recognize Tron as a valid UTXO/Send-type chain by adding chainId === tronChainId to the existing chain validation logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • feat: thorchain tron support #11266: Extensive addition of TRON support including introduction of tronChainId and treatment of Tron as a Thorchain send/UTXO path—directly aligned with this PR's expansion of Tron chain recognition.

Suggested reviewers

  • gomesalexandre

Poem

🐰 A Tron hops into view, so grand,
In Thorchain's UTXO land!
No longer lost in conditional night,
Tron's liquidity shines oh-so-bright! ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: tron lp deposits' directly addresses the main change: enabling Tron LP deposits by adding tronChainId to the getThorchainTransactionType logic.
Linked Issues check ✅ Passed The code change adds tronChainId support to getThorchainTransactionType, allowing Tron to be recognized as a Send-type chain, which directly addresses the requirement in issue #11574 to enable Tron LP deposits.
Out of Scope Changes check ✅ Passed The pull request only modifies getThorchainTransactionType to include tronChainId, which is directly scoped to fixing the Tron LP deposits issue with no extraneous changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch trx-lp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@NeOMakinG NeOMakinG marked this pull request as ready for review January 6, 2026 13:41
@NeOMakinG NeOMakinG requested a review from a team as a code owner January 6, 2026 13:41
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gm, no more crash on Tron deposit.

@0xApotheosis 0xApotheosis merged commit 3e67495 into develop Jan 7, 2026
4 checks passed
@0xApotheosis 0xApotheosis deleted the trx-lp branch January 7, 2026 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tron LP page gives oops error

3 participants