feat: reduce input whitespace when sending BTC #779
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Closing this, as I misread the issue description and added a functionality that was never needed. The real fix is a simple one-liner here: https://github.com/shapeshift/web/pull/803/files |
kaladinlight
pushed a commit
that referenced
this pull request
Apr 7, 2023
feat(investor-foxy): use "KnownChainIds" instead of "ChainTypes" BREAKING CHANGE: Requires updated peerDependencies
kaladinlight
pushed a commit
that referenced
this pull request
Apr 7, 2023
# [@shapeshiftoss/investor-foxy-v4.0.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/investor-foxy-v3.4.2...@shapeshiftoss/investor-foxy-v4.0.0) (2022-06-09) ### Features * **investor-yearn:** use "KnownChainIds" instead of "ChainTypes" ([#779](shapeshift/lib#779)) ([f44bc8f](shapeshift/lib@f44bc8f)) ### BREAKING CHANGES * **investor-yearn:** Requires updated peerDependencies
kaladinlight
pushed a commit
that referenced
this pull request
Apr 7, 2023
# [@shapeshiftoss/investor-yearn-v4.0.0](https://github.com/shapeshift/lib/compare/@shapeshiftoss/investor-yearn-v3.0.3...@shapeshiftoss/investor-yearn-v4.0.0) (2022-06-09) ### Features * **investor-yearn:** use "KnownChainIds" instead of "ChainTypes" ([#779](shapeshift/lib#779)) ([f44bc8f](shapeshift/lib@f44bc8f)) ### BREAKING CHANGES * **investor-yearn:** Requires updated peerDependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AddressInputcomponent if theassetto be sent is Bitcoinsmtomdfont sizes causes Native Segwit addresses to clip against the QR code buttonNotes for the reviewer
CAIP2used as a stable way to check if the asset being sent is BitcoinP2SHandP2PKHwill still show some whitespace) - we could go down the path of working out what kind of Bitcoin account type has been entered (if valid), but this gets messy and is likely not necessaryNotice
Before submitting a pull request, please make sure you have answered the following:
Pull Request Type
Issue (if applicable)
Addresses #735.
Testing
Please outline all testing steps
bc1qar0srrr7xfkvy5l643lydnw9re59gtzzwf5mdq3J98t1WpEZ73CNmQviecrnyiWrnqRhWNLy1BvBMSEYstWetqTFn5Au4m4GFg7xJaNVN2Screenshots (if applicable)
New design: