🐛 Add query validation #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawidreedsy
force-pushed
the
validate-mongo-query
branch
from
95deaf4 to
f052eeb
Compare
ericyhwang
reviewed
Nov 8, 2022
Contributor
ericyhwang
left a comment
ericyhwang
left a comment
There was a problem hiding this comment.
Comments from PR review meeting:
- Small lint fixes, Alec is adding the missing linter to the repo now
- Remove package-lock.json
index.js
Outdated
Comment on lines
144
to
145
| if(!isObject(query) || Array.isArray(query)) { | ||
| throw new Error('Invalid mongo query format') |
Contributor
There was a problem hiding this comment.
Space after if and semicolon at the end of the thrown error
index.js
Outdated
| ShareDBMingo.extendMemoryDB = extendMemoryDB; | ||
|
|
||
| module.exports = ShareDBMingo; | ||
| module.exports = ShareDBMingo; |
Contributor
There was a problem hiding this comment.
Add newline at end of file
dawidreedsy
force-pushed
the
validate-mongo-query
branch
3 times, most recently
from
164710d to
331586b
Compare
ericyhwang
approved these changes
Nov 8, 2022
dawidreedsy
force-pushed
the
validate-mongo-query
branch
2 times, most recently
from
402a49c to
4b146f5
Compare
Sending this query to the query mechanism:
```
{
$and: [
123,
{y: 1}
]
}
```
should throw the error however our function `castToSnapshotQuery`
changes it to:
```
{"$and":[{},{"data.y": 1}]}
```
Notice that the number `123` was converted to the empty object
dawidreedsy
force-pushed
the
validate-mongo-query
branch
from
4b146f5 to
8ff2a12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending this query to the query mechanism:
should throw the error, however our function
castToSnapshotQuerychanges it to:Notice that the number
123was converted to the empty object