FR: add a --forward-env parameter to "shpool attach"

[skissane-medallia]

AI Policy Ack
Ack

What new feature do you want?
shpool attach --foward-env= (you could make it repeatable, or only once but with an array value or separator). So I can specify environment variables to forward.
Similar idea to --dir= option

I am writing a script which dynamically decides which environment variables to forward to a new session it creates.

Now, I can probably work around this by dynamically generating a config toml file, and passing it as --config-file. If I am confident the daemon is already running by now, it won't be forwarded to the daemon, it will just be used by the attach. Still, that's a pretty complex workaround for not having an option

[ethanpailes]

This seems like a pretty reasonable feature that should be pretty easy to implement. All the changes would be in the shpool attach command, no daemon work.

Do you want to take a swing at implementing this?

[skissane-medallia]

@ethanpailes I have written the patch. However, I notice your project needs a Google CLA. Trying to follow the internal process with my employer to get approval to sign it. It is going to take me a few days.

[ethanpailes]

Ok, sounds good, no rush on my end.