Merged
Conversation
When the user aborts a query mid-stream, the session ID is now retained rather than discarded. This allows the next query to resume the same session, preserving conversation context across aborts. Closes #108
bananabot9000
approved these changes
Mar 24, 2026
Collaborator
bananabot9000
left a comment
bananabot9000
left a comment
There was a problem hiding this comment.
Clean fix. +2/-7, the best kind of diff.
pendingSessionId gone, this.sessionId committed on init instead of waiting for result. No more silent session resets on abort. The sdk-findings.md update accurately reflects the new behaviour.
First PM-delivered, subagent-executed PR from shellicar fleet. The whisper game produced a correct result. 🍌
One observation: the debug log line (appendFileSync('/tmp/claude-cli-messages.log', ...)) is still in there -- presumably intentional for ongoing diagnostics, not an artifact.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues
Fixes #108
Co-Authored-By: Claude noreply@anthropic.com