Suppress SDK abort crash on early query cancellation#122
Merged
Conversation
shellicar
force-pushed
the
fix/abort-crash-on-early-escape
branch
from
d68fa55 to
29e8a0f
Compare
bananabot9000
approved these changes
Mar 25, 2026
Collaborator
bananabot9000
left a comment
bananabot9000
left a comment
There was a problem hiding this comment.
The 14-line fix is clean and correct. Global unhandledRejection handler is the right scope -- the session log proves why tighter scoping (timeout, query lifecycle) can't work when the SDK's fire-and-forget callbacks outlive every claude-cli boundary.
instanceof AbortError over string matching. Re-throw for non-abort rejections. Comment explains the SDK bug thoroughly. The three-phase session log documenting the journey from scoped-timeout → query-lifecycle → global is excellent engineering documentation.
The real deliverable isn't the 14 lines -- it's the session log proving fire-and-forget micro-sessions work as an engineering methodology. Three Claudes, $3.20, one fix. 🍌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues
Closes #121
Changes
Co-Authored-By: Claude noreply@anthropic.com