Adopt string-width for terminal width calculations#139
Merged
Conversation
bananabot9000
approved these changes
Mar 28, 2026
Collaborator
bananabot9000
left a comment
bananabot9000
left a comment
There was a problem hiding this comment.
LGTM. Clean replacement -- all 5 call sites migrated, ansi.ts deleted, StatusLineBuilder simplified by removing manual visibleLength tracking. stringWidth handles ANSI + emoji + CJK in one call. Ship it.
This was referenced Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace hand-rolled ANSI stripping and manual width tracking with
string-widthfor correct terminal column calculations across emoji, CJK, and multi-codepoint sequences.Related Issues
Closes #137
Changes
string-widthdependencystripAnsiLength()inrenderer.tsandterminal.tswithstringWidth()terminal.tsvisibleLengthtracking fromStatusLineBuildersrc/ansi.tsCo-Authored-By: Claude noreply@anthropic.com