Fix cursor navigation in wrapped editor lines#144
Merged
Conversation
bananabot9000
approved these changes
Mar 28, 2026
Collaborator
bananabot9000
left a comment
There was a problem hiding this comment.
LGTM. The wrap-aware cursor navigation logic in moveUp/moveDown is correct -- subRow calculation, cross-line boundary handling, prefix width accounting all check out. terminal.ts simplification (editorScreenLines - cursorRow - 1 and cursorCol % columns) is a nice cleanup.
Cleanup notes (non-blocking):
- Prompt string construction in
ClaudeCli.tsis duplicated between up/down cases and likely duplicated from wherever the prompt is originally built. AgetPromptWidth()helper would prevent drift. byteOffsetAtVisualWidthreturns a code unit offset, not a byte offset. Minor naming inaccuracy.- The duplicated variable naming (
busyUp/busyDown,colsUp/colsDown) could be shared -- both cases use the same values.
Manually verified by author. Ship it.
This was referenced Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #135
Co-Authored-By: Claude noreply@anthropic.com