Prevent sticky zone from overflowing terminal viewport#145
Merged
Conversation
bananabot9000
approved these changes
Mar 28, 2026
Collaborator
bananabot9000
left a comment
There was a problem hiding this comment.
The updated version addresses the height budget concern from my earlier review. The implementation is clean and well-structured:
What I like:
- Components pre-built into typed parts before budget allocation — clean separation of "what exists" from "what fits"
- Priority-based drop order (preview → attachments → questions → status) matches user expectations
minEditorRows = 1guarantee prevents the editor from disappearing entirelylineStartRow[]map for O(1) viewport slicing instead of re-scanning- Cursor chasing with
scrollOffsetmax cap and line boundary snapping visibleCursorRow = cursorRow - scrollOffset— simple and correct
Minor observations (non-blocking):
- The scroll offset logic is straightforward — it's literally a number that goes up and down, capped at bounds. No complexity concerns.
- Terminal disappearing (VS Code drag-to-hide) bottoms at
rows=2per testing, so theminEditorRows=1guard covers this naturally.
Solid implementation. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues
Closes #134
Co-Authored-By: Claude noreply@anthropic.com