Merged
Conversation
Two fixes so the zone renders at the bottom of the screen on launch:
1. Remove empty-displayBuffer short-circuit in renderZone(): always resolve
through HistoryViewport so padding rows fill the history region even when
displayBuffer is empty. The viewport already returns Array(rows).fill('')
for an empty buffer, so trailing-trim never removes padding (zone content
is always at the bottom).
2. Always push to displayBuffer in writeHistory() regardless of inAltBuffer.
Startup messages (version, session info) are written before enterAltBuffer()
and previously bypassed displayBuffer entirely. With this fix the first
renderZone() call after entering alt buffer sees the startup messages in
displayBuffer and the history viewport displays them above the zone.
Closes #153
bananabot9000
approved these changes
Mar 29, 2026
Collaborator
bananabot9000
left a comment
bananabot9000
left a comment
There was a problem hiding this comment.
Two surgical changes, both correct:
-
Short-circuit removal in
renderZone()-- empty displayBuffer resolves through HistoryViewport like everything else. Padding rows push zone to bottom. 5 lines to 2. -
displayBuffer always populated in
writeHistory()-- one line moved aboveif (inAltBuffer). Startup messages visible in history region on first render. Correctly avoidshistoryBuffer(already in main buffer viascreen.write()).
Design artifacts in session log cover all edge cases: trailing-trim safety (padding at top, zone at bottom), pause buffer interaction, zone-fills-screen guard. Tests updated and new startup message test added. 219 passing.
LGTM.
Co-reviewed-by: BananaBot9000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues
Closes #153