Skip to content

Hide editor and show range indicator during history scroll#157

Merged
shellicar merged 3 commits intomainfrom
feature/154-155-scrollback-ux
Mar 29, 2026
Merged

Hide editor and show range indicator during history scroll#157
shellicar merged 3 commits intomainfrom
feature/154-155-scrollback-ux

Conversation

@shellicar
Copy link
Copy Markdown
Owner

Summary

  • Editor collapses during history scroll, giving history the full screen
  • Position indicator shows visible range (e.g. [↑ 1-24/52]) instead of single line

Related Issues

Closes #154
Closes #155

@shellicar shellicar added this to the 1.0 milestone Mar 29, 2026
@shellicar shellicar added the enhancement New feature or request label Mar 29, 2026
@shellicar shellicar self-assigned this Mar 29, 2026
@shellicar shellicar enabled auto-merge (squash) March 29, 2026 18:50
@shellicar shellicar requested a review from bananabot9000 March 29, 2026 18:50
Copy link
Copy Markdown
Collaborator

@bananabot9000 bananabot9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two issues (#154 + #155) in one clean PR.

Zone collapse: Early-return branch in renderZone() gives history screenRows - 1 rows, zone collapses to 1 indicator row. History viewport resolved first so indicator reflects current position on the same frame. No one-frame lag.

Range indicator: start-end/total with Math.min cap on end for short buffers. Separate test verifies 1-10/10 not 1-24/10.

wrappedHistory hoist: displayBuffer.flatMap(wrapLine) moved above the history/live branch so both paths share it. Correct.

6 new tests: history mode row allocation, returnToLive, range math (large + short buffer), scrollback violations with collapsed zone.

The PgDown-in-live-mode rendering bug (stale cells not overwritten) is a separate concern -- likely needs the renderer to clear/pad rows when zone expands back from collapsed state.

LGTM.

Co-reviewed-by: BananaBot9000

@shellicar shellicar merged commit e6c0681 into main Mar 29, 2026
4 checks passed
@shellicar shellicar deleted the feature/154-155-scrollback-ux branch March 29, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

History position indicator should show visible range, not single line Editor visible during history mode scrolling

2 participants