Move key handling into EditorState.handleKey (step 3b)#190
Conversation
All editor key transitions now live in EditorState: enter, backspace, delete, ctrl+backspace/delete/k/u, left/right/up/down, home/end, ctrl+home/end, ctrl+left/right, and char. The word-navigation helpers (wordStartLeft, wordEndRight) moved with them as private methods. handleKey returns true when it consumed the key so the caller knows to schedule a re-render. It returns false for ctrl+enter (which involves attachments and a promise resolve that live in AppLayout) and for unknown keys. AppLayout.handleKey collapses from a 220-line switch to a four-line delegate plus the ctrl+enter block. The lines getter now returns readonly string[] — the type reflects that AppLayout reads it for rendering only; all mutations go through handleKey or reset. 56 unit tests cover every key case as pure state assertions.
bananabot9000
left a comment
bananabot9000
left a comment
There was a problem hiding this comment.
Textbook state extraction 🍌
220 lines of key handling → EditorState.handleKey() returning boolean (consumed/not-mine). Clean delegate pattern. AppLayout collapses to ~4 lines for the editor path plus the ctrl+enter submit block.
Boundary is right: ctrl+enter stays in AppLayout (touches #attachments, #editorResolve — not editor state). Everything that affects text/cursor is in EditorState. Everything that affects the app stays out.
readonly string[] on lines getter — compile-time enforcement that AppLayout can't accidentally mutate. Public setters removed. All mutation is internal to EditorState now. The contract from 3a is tightened.
56 tests covering every key case as pure state assertions. Boundary cases included (col 0 backspace, line 0 up-arrow, word nav with trailing spaces). ctrl+enter and unknown keys explicitly tested to return false.
One observation (not blocking): every editor key returns true even when no state changed (e.g. up-arrow at line 0). This means a no-op still triggers a render. Fine for now — it's a render performance knob for later if needed.
text getter from 3a correctly reused in the ctrl+enter path. JSDoc updated. KeyAction is a type-only import — no runtime dependency on the input layer.
Ship it 🚢🍌
2 participants
What
All editor key transitions move from
AppLayoutintoEditorState.handleKey.Changes
EditorState.handleKey(key: KeyAction): boolean— handles every editing key; returnstruewhen consumed so the caller schedules a re-render,falseforctrl+enterand unknown keys#wordStartLeft/#wordEndRightmove fromAppLayoutintoEditorStateas private helperslinesgetter now returnsreadonly string[]— enforces that AppLayout only reads for renderingAppLayout.handleKeycollapses from a 220-line switch to four lines: delegate tohandleKey, schedule render, then handlectrl+enterinlinectrl+enterstays inAppLayout: it reads#attachmentsand resolves#editorResolve, which are not editor stateTesting
56 unit tests in
EditorState.spec.tscover every key case as pure state assertions — no ANSI, no rendering, no terminal.