Fix startup banner position and tool cycle expanded state#201
Merged
Fix startup banner position and tool cycle expanded state#201
Conversation
Two unrelated UX bugs fixed together as both are small. **Startup banner pushed off screen on long sessions** showStartupBanner was called before addHistoryBlocks, making the banner the first block in the conversation. On sessions with enough history to fill the viewport, the banner scrolled off the top and was never visible. Moved the call to after history replay so the banner sits immediately above the first prompt where it is always seen. **Left/right cycling collapses expanded tool input** selectPrev and selectNext both set #toolExpanded = false, so pressing an arrow key while a tool's input was expanded would immediately collapse it. The intent of resetExpanded (called on return to editor mode) already covers the right teardown point. Removed the collapse from selectPrev and selectNext so expanded state is preserved while navigating tools. Tests updated to reflect the new expected behaviour.
shellicar
force-pushed
the
fix/startup-banner-and-tool-cycle
branch
from
4fc53d2 to
f24193f
Compare
bananabot9000
approved these changes
Apr 6, 2026
Collaborator
bananabot9000
left a comment
bananabot9000
left a comment
There was a problem hiding this comment.
Two clean fixes, both well-scoped 🍌
Banner position: Moving showStartupBanner after addHistoryBlocks is the obvious correct fix. Banner should be the last thing before the prompt, not the first thing in the buffer.
Tool cycle expanded state: The old behaviour (collapse on arrow key) was clearly a UX bug -- if you expand a tool to read it, cycling to the next tool shouldn't collapse the view. resetExpanded still handles the teardown when exiting approval mode, so there's no state leak.
Tests updated correctly: "collapses" → "preserves", expected flipped to true.
Session log is noise but documents the context well.
Approved ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small UX bugs.
Startup banner pushed off screen
showStartupBannerwas called beforeaddHistoryBlocks, making the banner the first block in the conversation. On sessions with enough history to fill the viewport it scrolled off the top and was never visible.Moved the call to after history replay so the banner always sits immediately above the first prompt.
Left/right cycling collapses expanded tool input
selectPrevandselectNextboth set#toolExpanded = false, so pressing an arrow key while a tool's input was expanded would immediately collapse it.resetExpanded(called on return to editor mode) already handles the right teardown point.Removed the collapse from
selectPrevandselectNextso expanded state is preserved while navigating between tools.