Skip to content
This repository was archived by the owner on Apr 11, 2026. It is now read-only.

Fix circular dependency detection and self-dependency check#19

Merged
shellicar merged 5 commits intomainfrom
fix/circular-dependency-detection
Feb 22, 2026
Merged

Fix circular dependency detection and self-dependency check#19
shellicar merged 5 commits intomainfrom
fix/circular-dependency-detection

Conversation

@shellicar
Copy link
Copy Markdown
Owner

Summary

  • Add circular dependency detection that throws CircularDependencyError instead of silently stack overflowing
  • Fix self-dependency check that was unreachable due to comparing abstract class against concrete class
  • Add CircularDependencyError exported error class
  • Add 7 tests covering self-dependency, 2-node cycles, and 3-node cycles across all lifetimes

Co-Authored-By: Claude noreply@anthropic.com

@shellicar shellicar added this to the 3.1.4 milestone Feb 22, 2026
@shellicar shellicar self-assigned this Feb 22, 2026
@shellicar shellicar added the bug Something isn't working label Feb 22, 2026
@shellicar shellicar force-pushed the fix/circular-dependency-detection branch from 76efbe6 to b5139ba Compare February 22, 2026 09:35
@shellicar shellicar merged commit a3d7bc8 into main Feb 22, 2026
2 checks passed
@shellicar shellicar deleted the fix/circular-dependency-detection branch February 22, 2026 09:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant