Skip to content
This repository was archived by the owner on Apr 11, 2026. It is now read-only.

Fix singleton disposal#21

Merged
shellicar merged 2 commits intomainfrom
fix/singleton-disposal
Feb 22, 2026
Merged

Fix singleton disposal#21
shellicar merged 2 commits intomainfrom
fix/singleton-disposal

Conversation

@shellicar
Copy link
Copy Markdown
Owner

Summary

  • Fix root provider to dispose singleton IDisposable instances on disposal, matching MS DI behaviour
  • Add IDisposable implementation to IServiceProvider interface
  • Refactor ServiceProvider to use private constructor with static createRoot factory
  • Add 4 disposal lifecycle tests covering singleton, scoped, and transient lifetimes

Co-Authored-By: Claude noreply@anthropic.com

@shellicar shellicar added this to the 3.1.5 milestone Feb 22, 2026
@shellicar shellicar added the bug Something isn't working label Feb 22, 2026
@shellicar shellicar self-assigned this Feb 22, 2026
@shellicar shellicar merged commit 82c9d46 into main Feb 22, 2026
3 checks passed
@shellicar shellicar deleted the fix/singleton-disposal branch February 22, 2026 14:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant