Merged
Conversation
Three changes to npm-publish.yml: 1. Build steps now scope to the released package using turbo filters (--filter=./packages/<name>...) instead of running all packages. Lint still runs repo-wide via biome ci. 2. Resolve package directory simplified: derives path by convention (packages/<tag-prefix>) and verifies the package.json name matches @shellicar/<tag-prefix>, rather than scanning all directories. 3. Added workflow_dispatch trigger with a tag input for dry-run testing. When dispatched manually, the publish step passes --dry-run so nothing is uploaded to npm. Useful for testing the workflow after runner or permission changes without creating a real release.
The ci script used --changed --since=origin/main, which breaks when a PR only touches files biome cannot process (YAML, etc.). Biome errors with "No files were processed." Dropping --changed so it runs on the full repo, matching the approach used in the release workflow.
0651c7c to
8401bd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope release workflow CI to the released package only, simplify directory resolution, and add manual dispatch for dry-run testing.
Changes
--filter=./packages/<name>...instead of running all packagesbiome ci --diagnostic-level=errorResolve package directoryderives path by convention (packages/<tag-prefix>) then verifies the package.json name matches@shellicar/<tag-prefix>workflow_dispatchtrigger withtaginput for manual dry-run testing--dry-runwhen triggered via dispatchCo-Authored-By: Claude noreply@anthropic.com