fix: Replace hard assertion on SendARP output length with a regular check in the enclosing if statement#131
Merged
shellrow merged 1 commit intoshellrow:mainfrom Sep 5, 2025
Le-Maz:main
Merged
fix: Replace hard assertion on SendARP output length with a regular check in the enclosing if statement#131shellrow merged 1 commit intoshellrow:mainfrom Le-Maz:main
shellrow merged 1 commit intoshellrow:mainfrom
Le-Maz:main
Conversation
Owner
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the unconditional
assert_eq!(out_buf_len, 6)when retrieving a MAC address viaSendARPon Windows.I encountered an error with a virtual network adapter that a zero was set as MAC length, which caused a panic at runtime. With this change, the assertion is instead a part of the if statement checking for errors.