Skip to content

Update options.client typings#105

Merged
matheus1lva merged 1 commit intoshellscape:masterfrom
stnwk:patch-1
Jan 31, 2019
Merged

Update options.client typings#105
matheus1lva merged 1 commit intoshellscape:masterfrom
stnwk:patch-1

Conversation

@stnwk
Copy link
Contributor

@stnwk stnwk commented Jan 31, 2019

This PR contains:

  • bugfix
  • feature
  • refactor
  • tests
  • documentation
  • metadata

Breaking Changes?

  • yes
  • no

Please Describe Your Changes

This PR only updates the typings file.

- Adds an optional `client.silent` boolean (was forgotten in shellscape#97)
- Marks all other options in `client` as optional too
Copy link
Collaborator

@matheus1lva matheus1lva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Yeah, we missed that! Good catch!

@matheus1lva matheus1lva merged commit 0d30966 into shellscape:master Jan 31, 2019
@stnwk stnwk deleted the patch-1 branch January 31, 2019 10:53
@stnwk
Copy link
Contributor Author

stnwk commented Jan 31, 2019

You're welcome 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants