fix(routes): Allow HMR with warnings#106
Merged
shellscape merged 1 commit intoshellscape:masterfrom Feb 5, 2019
artembatura:fix/routes
Merged
fix(routes): Allow HMR with warnings#106shellscape merged 1 commit intoshellscape:masterfrom artembatura:fix/routes
shellscape merged 1 commit intoshellscape:masterfrom
artembatura:fix/routes
Conversation
4 tasks
shellscape
reviewed
Feb 4, 2019
| socket.lastHash = hash; | ||
|
|
||
| const { errors = [], warnings = [] } = stats.toJson(statsOptions); | ||
| const hasErrors = Boolean(errors.length); |
Owner
There was a problem hiding this comment.
curious about this assertion. we're only in need of a truthy/falsy value here. was there an explicit need to case to Boolean?
Author
There was a problem hiding this comment.
Yeah, this doesn't change much using Boolean. It's more stricter perhaps ^o^
And next I simply reuse value
Instead of this:
if (errors.length || warnings.length) {
...
if (errors.length) return;
}I written:
const hasErrors = Boolean(errors.length);
if (hasErrors || warnings.length) {
...
if (hasErrors) return;
}
shellscape
approved these changes
Feb 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
If yes, please describe the breakage.
Please Describe Your Changes
We have two message types, which contains information about problems when Application building. There are warnings and errors. Currently when error or warning are detected,
webpack-plugin-servedoesn't replace changed files. This PR allow apply changes to files by HMR if get any warning, because warning it's not critical problem, which affect on build process. Warnings never stopping building process. For example, warning from ESLint (eslint-loader)