handle uncaughtException#114
Merged
shellscape merged 2 commits intoshellscape:masterfrom Mar 18, 2019
Merged
Conversation
I do not know exactly what is the case in which this issue occurs, however this change should be enough to fix the issue.
Stacktrace:
```
uncaughtException TypeError: filePath.replace is not a function
at WebpackPluginServe.socket.invalid (/project/node_modules/webpack-plugin-serve/lib/routes.js:80:35)
at WebpackPluginServe.emit (events.js:194:15)
at invalid.tap (/project/node_modules/webpack-plugin-serve/lib/index.js:155:41)
at SyncHook.eval (eval at create (/project/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:7:1)
at Watchpack.watcher.compiler.watchFileSystem.watch (/project/node_modules/webpack/lib/Watching.js:139:33)
at Object.onceWrapper (events.js:277:13)
at Watchpack.emit (events.js:189:13)
at Watchpack._onChange (/project/node_modules/watchpack/lib/watchpack.js:118:7)
at Watchpack.<anonymous> (/project/node_modules/watchpack/lib/watchpack.js:109:8)
at Watcher.emit (events.js:189:13)
at /project/node_modules/watchpack/lib/DirectoryWatcher.js:101:9
at Array.forEach (<anonymous>)
at DirectoryWatcher.setFileTime (/project/node_modules/watchpack/lib/DirectoryWatcher.js:99:42)
at DirectoryWatcher.onChange (/project/node_modules/watchpack/lib/DirectoryWatcher.js:264:7)
at FSWatcher.emit (events.js:189:13)
at FSWatcher.<anonymous> (/project/node_modules/watchpack/node_modules/chokidar/index.js:199:15)
at /project/node_modules/watchpack/node_modules/chokidar/index.js:238:7
at FSReqWrap.oncomplete (fs.js:155:5)
```
matheus1lva
reviewed
Mar 5, 2019
Collaborator
matheus1lva
left a comment
matheus1lva
left a comment
There was a problem hiding this comment.
apparently webpack is returning other than a string for the filename when an invalid compilation happens... interesting.
matheus1lva
approved these changes
Mar 5, 2019
shellscape
reviewed
Mar 5, 2019
shellscape
reviewed
Mar 5, 2019
Co-Authored-By: niieani <bazyli.brzoska@gmail.com>
Owner
|
My apologies for the delay in merging this. Really do appreciate the PR. |
smashercosmo
pushed a commit
to smashercosmo/webpack-plugin-serve
that referenced
this pull request
Jul 23, 2019
* handle uncaughtException
I do not know exactly what is the case in which this issue occurs, however this change should be enough to fix the issue.
Stacktrace:
```
uncaughtException TypeError: filePath.replace is not a function
at WebpackPluginServe.socket.invalid (/project/node_modules/webpack-plugin-serve/lib/routes.js:80:35)
at WebpackPluginServe.emit (events.js:194:15)
at invalid.tap (/project/node_modules/webpack-plugin-serve/lib/index.js:155:41)
at SyncHook.eval (eval at create (/project/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:7:1)
at Watchpack.watcher.compiler.watchFileSystem.watch (/project/node_modules/webpack/lib/Watching.js:139:33)
at Object.onceWrapper (events.js:277:13)
at Watchpack.emit (events.js:189:13)
at Watchpack._onChange (/project/node_modules/watchpack/lib/watchpack.js:118:7)
at Watchpack.<anonymous> (/project/node_modules/watchpack/lib/watchpack.js:109:8)
at Watcher.emit (events.js:189:13)
at /project/node_modules/watchpack/lib/DirectoryWatcher.js:101:9
at Array.forEach (<anonymous>)
at DirectoryWatcher.setFileTime (/project/node_modules/watchpack/lib/DirectoryWatcher.js:99:42)
at DirectoryWatcher.onChange (/project/node_modules/watchpack/lib/DirectoryWatcher.js:264:7)
at FSWatcher.emit (events.js:189:13)
at FSWatcher.<anonymous> (/project/node_modules/watchpack/node_modules/chokidar/index.js:199:15)
at /project/node_modules/watchpack/node_modules/chokidar/index.js:238:7
at FSReqWrap.oncomplete (fs.js:155:5)
```
* pass down the filePath verbatim
Co-Authored-By: niieani <bazyli.brzoska@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
If yes, please describe the breakage.
Please Describe Your Changes
I do not know exactly what is the case in which this issue occurs, however this change should be enough to fix the issue.
Stacktrace: