Conversation
bebraw
approved these changes
Apr 8, 2019
matheus1lva
approved these changes
Apr 8, 2019
smashercosmo
pushed a commit
to smashercosmo/webpack-plugin-serve
that referenced
this pull request
Jul 23, 2019
* feat: custom headers option * test: fix validation, nulls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
Please Describe Your Changes
Fixes #37 and adds a custom header feature as requested by @kurtextrem.
While we have no CI tests in place, I verified locally that this does function correctly.
(Note: we really need to get on a method to test middleware)