docs: Fix typo in README.md#126
Merged
shellscape merged 1 commit intoshellscape:masterfrom Apr 14, 2019
G-Rath:patch-1
Merged
Conversation
shellscape
reviewed
Apr 13, 2019
|
|
||
| ## TypeScript Types | ||
|
|
||
| To get type defifinitions for this project: |
Contributor
Author
There was a problem hiding this comment.
defifinitely, but I was worried if the README found out people were laughing at it behind its back, it could ruin its self-confidence.
I didn't think it was worth the risk of having to deal with a depressed & unconfident README.
Collaborator
There was a problem hiding this comment.
this made my day HAHAHAHAHAHAH
smashercosmo
pushed a commit
to smashercosmo/webpack-plugin-serve
that referenced
this pull request
Jul 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
If yes, please describe the breakage.
Please Describe Your Changes
Fixed a spelling mistake.
I've tested this fix locally, and it seems to work fine, but it could still be a breaking change since there are no tests covering
README.md.