Skip to content

fix: static regression when passing array#134

Merged
shellscape merged 2 commits intomasterfrom
fix/static-array
May 5, 2019
Merged

fix: static regression when passing array#134
shellscape merged 2 commits intomasterfrom
fix/static-array

Conversation

@shellscape
Copy link
Owner

@shellscape shellscape commented May 5, 2019

This PR contains:

  • bugfix
  • feature
  • refactor
  • tests
  • documentation
  • metadata

Breaking Changes?

  • yes
  • no

Users relying on passing an Array[String] to use globs will need to update to use a new format (described below).

Please Describe Your Changes

Fixes #133

v0.9.0 introduced a regression with regard to passing Array[String] to the static option. globby would take over and return the list of files in the passed directory(s). That was incorrect behavior. This PR fixes that regression by restoring the prior behavior of Array[String], and introduces a new value format for the static for users wanting to use globs:

static: {
  glob: [ ... ],
  options: { ... }
}

See the changes to README for more info.

@shellscape shellscape merged commit ecf03f3 into master May 5, 2019
@shellscape shellscape deleted the fix/static-array branch May 5, 2019 05:51
smashercosmo pushed a commit to smashercosmo/webpack-plugin-serve that referenced this pull request Jul 23, 2019
* fix: static regression when passing array

* chore: clearer readme example, fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v0.9.0 breaks my project (constant "Not Found / 404" results)

2 participants