fix: static regression when passing array#134
Merged
shellscape merged 2 commits intomasterfrom May 5, 2019
Merged
Conversation
bebraw
reviewed
May 5, 2019
bebraw
approved these changes
May 5, 2019
27e9dbe to
aca8e51
Compare
smashercosmo
pushed a commit
to smashercosmo/webpack-plugin-serve
that referenced
this pull request
Jul 23, 2019
* fix: static regression when passing array * chore: clearer readme example, fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
Users relying on passing an
Array[String]to use globs will need to update to use a new format (described below).Please Describe Your Changes
Fixes #133
v0.9.0 introduced a regression with regard to passing
Array[String]to thestaticoption. globby would take over and return the list of files in the passed directory(s). That was incorrect behavior. This PR fixes that regression by restoring the prior behavior ofArray[String], and introduces a new value format for thestaticfor users wanting to use globs:See the changes to README for more info.