Skip to content

feat: ramdisk option, webpack-plugin-ramdisk implementation#145

Merged
shellscape merged 8 commits intomasterfrom
feat/ramdisk
Jul 24, 2019
Merged

feat: ramdisk option, webpack-plugin-ramdisk implementation#145
shellscape merged 8 commits intomasterfrom
feat/ramdisk

Conversation

@shellscape
Copy link
Owner

This PR contains:

  • bugfix
  • feature
  • refactor
  • tests
  • documentation
  • metadata

Breaking Changes?

  • yes
  • no

Please Describe Your Changes

This feature adds a new ramdisk option to the configuration, which can enable the use of webpack-plugin-ramdisk to improve build emit performance (especially useful during hmr/liveReload use).

@shellscape
Copy link
Owner Author

@ndelangen please review

@shellscape shellscape requested a review from TrySound July 19, 2019 14:41
@shellscape
Copy link
Owner Author

@cpylua @TrySound just pushed a bunch more changes based on feedback, and some error conditions that might come up. please have another look.

Copy link
Collaborator

@bebraw bebraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Is it possible to reduce the amount of istanbul ignores?
  • Are the snapshots system independent? I see some path errors that might need some normalization to work across multiple developers. i.e. /Users/powella/....

@shellscape
Copy link
Owner Author

Is it possible to reduce the amount of istanbul ignores?

Not necessary. The blocks that are ignored don't need to be analyzed for coverage.

Are the snapshots system independent? I see some path errors that might need some normalization to work across multiple developers. i.e. /Users/powella/....

That's really weird that CI passed with those in there.

@shellscape
Copy link
Owner Author

Since there doesn't appear to be any functional objection, I'm probably going to release this later today one I fix up that test snapshot.

@shellscape shellscape merged commit ac29af8 into master Jul 24, 2019
@shellscape shellscape deleted the feat/ramdisk branch July 24, 2019 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants