feat: ramdisk option, webpack-plugin-ramdisk implementation#145
Merged
shellscape merged 8 commits intomasterfrom Jul 24, 2019
Merged
feat: ramdisk option, webpack-plugin-ramdisk implementation#145shellscape merged 8 commits intomasterfrom
shellscape merged 8 commits intomasterfrom
Conversation
Owner
Author
|
@ndelangen please review |
TrySound
approved these changes
Jul 18, 2019
cpylua
reviewed
Jul 19, 2019
cpylua
reviewed
Jul 19, 2019
cpylua
reviewed
Jul 19, 2019
Owner
Author
cpylua
reviewed
Jul 20, 2019
cpylua
reviewed
Jul 20, 2019
bebraw
reviewed
Jul 21, 2019
Collaborator
bebraw
left a comment
There was a problem hiding this comment.
- Is it possible to reduce the amount of istanbul ignores?
- Are the snapshots system independent? I see some path errors that might need some normalization to work across multiple developers. i.e.
/Users/powella/....
Owner
Author
Not necessary. The blocks that are ignored don't need to be analyzed for coverage.
That's really weird that CI passed with those in there. |
Owner
Author
|
Since there doesn't appear to be any functional objection, I'm probably going to release this later today one I fix up that test snapshot. |
ndelangen
reviewed
Jul 22, 2019
ndelangen
approved these changes
Jul 22, 2019
matheus1lva
approved these changes
Jul 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
Please Describe Your Changes
This feature adds a new
ramdiskoption to the configuration, which can enable the use ofwebpack-plugin-ramdiskto improve build emit performance (especially useful during hmr/liveReload use).