Skip to content

chore: Add note to readme about HMR with HTTP2#184

Merged
shellscape merged 1 commit intoshellscape:masterfrom
illusionalsagacity:fix/update-readme
Sep 6, 2020
Merged

chore: Add note to readme about HMR with HTTP2#184
shellscape merged 1 commit intoshellscape:masterfrom
illusionalsagacity:fix/update-readme

Conversation

@illusionalsagacity
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • tests
  • documentation
  • metadata

Breaking Changes?

  • yes
  • no

If yes, please describe the breakage.

Please Describe Your Changes

This fixes #183, documenting the case for using HMR with a HTTP2 dev server.

@shellscape
Copy link
Owner

Given websockets/ws#1458, this PR is good. We might want to consider automatically turning that option on as well.

thanks!

@shellscape shellscape merged commit 6a78f0f into shellscape:master Sep 6, 2020
@illusionalsagacity illusionalsagacity deleted the fix/update-readme branch September 7, 2020 13:16
@illusionalsagacity
Copy link
Contributor Author

illusionalsagacity commented Sep 8, 2020

@shellscape if you like I can PR that change to turn it on by default as well

@shellscape
Copy link
Owner

I don't see a reason not to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTTP2 with HMR is not documented

2 participants