Conversation
Joi has a poor documentation and hard to find changelog in issues. In this diff I migrated to suggested by @shellscape "superstruct" which does not have dependencies and simpler to extend.
shellscape
reviewed
Oct 8, 2020
lib/validate.js
Outdated
| ] | ||
| }; | ||
| const promise = refinement(any(), 'promise-like', (value) => { | ||
| console.log(value, isPromise(value)); |
Owner
There was a problem hiding this comment.
we'll probably want to delete this one yeah?
bebraw
approved these changes
Oct 8, 2020
TrySound
added a commit
to shellscape/webpack-plugin-ramdisk
that referenced
this pull request
Oct 8, 2020
8 tasks
shellscape
pushed a commit
to shellscape/webpack-plugin-ramdisk
that referenced
this pull request
Oct 9, 2020
bz2
added a commit
to bz2/license-checker-webpack-plugin
that referenced
this pull request
Nov 14, 2020
The joi validation package is deprecated/moving repository. Going off shellscape/webpack-plugin-serve#188 superstruct seems a solid replacement. Basic validation works fine, and can be customised as needed. Add some tests for option validation.
unindented
pushed a commit
to microsoft/license-checker-webpack-plugin
that referenced
this pull request
Nov 15, 2020
The joi validation package is deprecated/moving repository. Going off shellscape/webpack-plugin-serve#188 superstruct seems a solid replacement. Basic validation works fine, and can be customised as needed. Add some tests for option validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
If yes, please describe the breakage.
Please Describe Your Changes
Joi has a poor documentation and hard to find changelog in issues.
In this diff I migrated to suggested by @shellscape "superstruct"
which does not have dependencies and simpler to extend.