Fix/error on hmr when file path is null#213
Merged
shellscape merged 2 commits intoshellscape:masterfrom Mar 13, 2021
zauan:fix/error-on-hmr-when-filePath-is-null
Merged
Fix/error on hmr when file path is null#213shellscape merged 2 commits intoshellscape:masterfrom zauan:fix/error-on-hmr-when-filePath-is-null
shellscape merged 2 commits intoshellscape:masterfrom
zauan:fix/error-on-hmr-when-filePath-is-null
Conversation
…ndow' When building a library and use a multi entry config, only the last item in the entry array will be exposed. The example that was provided by the plugin would expose the webpack plugin serve client in the end file and it breaks the app
filePath on webpack invalid hook can return filePath or null. This resolves the following error when it returns null Cannot read property 'replace' of null
Owner
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
If yes, please describe the breakage.
Please Describe Your Changes
The invalid hook from webpack filePath argument can be a string or null ( https://github.com/webpack/webpack/blob/64fb5f33f7b242fdbe8da453f793dbf95f4699e8/lib/Compiler.js#L168 ). This resolves a problem when the filePath is null ( the server throws an error and closes )