Fixed invalid chunkFileName#214
Merged
shellscape merged 1 commit intoshellscape:masterfrom Mar 13, 2021
zauan:fix/webpack-5-hotUpdateChunkFilename
Merged
Fixed invalid chunkFileName#214shellscape merged 1 commit intoshellscape:masterfrom zauan:fix/webpack-5-hotUpdateChunkFilename
shellscape merged 1 commit intoshellscape:masterfrom
zauan:fix/webpack-5-hotUpdateChunkFilename
Conversation
As per Webpack documentation, [runtime] can be used only for hotUpdateMainFilename and not hotUpdateChunkFilename ( https://webpack.js.org/configuration/output/#outputhotupdatechunkfilename ). By having this template string inside outputhotupdatechunkfilename , the HMR breaks
bz2
approved these changes
Feb 23, 2021
Contributor
bz2
left a comment
bz2
left a comment
There was a problem hiding this comment.
Thanks! Also hit this issue after upgrading, and have verified locally that this change resolves the broken urls.
Owner
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
If yes, please describe the breakage.
Please Describe Your Changes
As per Webpack documentation, [runtime] can be used only for hotUpdateMainFilename and not hotUpdateChunkFilename ( https://webpack.js.org/configuration/output/#outputhotupdatechunkfilename ). By having this template string inside outputhotupdatechunkfilename , the HMR breaks as chunk file names will have an incorrect name and the files won't be found on the server