Add client.protocol override option for client#218
Merged
shellscape merged 4 commits intoshellscape:masterfrom Mar 13, 2021
Merged
Add client.protocol override option for client#218shellscape merged 4 commits intoshellscape:masterfrom
client.protocol override option for client#218shellscape merged 4 commits intoshellscape:masterfrom
Conversation
Enables users of reverse proxies to specify a different protocol scheme for client requests (typically `wss` from the browser) from the protocol scheme served by the server (typically `ws`).
shellscape
reviewed
Mar 10, 2021
shellscape
reviewed
Mar 10, 2021
Owner
|
Looks good 👍 Just a small variable name reversion I'd appreciate. |
Co-authored-by: Andrew Powell <shellscape@users.noreply.github.com>
Contributor
Author
|
@shellscape done! |
Owner
|
|
Contributor
Author
|
@shellscape any idea when we can expect an npm release with this new feature? I'm itching to get it into our local dev environment! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
If yes, please describe the breakage.
Please Describe Your Changes
Small, yet important (for me, at least :p) update: enables users of reverse proxies to specify a different protocol scheme for client requests (typically
wssfrom the browser) from the protocol scheme served by the server (typicallyws).Provides the final, necessary tool to resolve: #172.