make sure wrapper is found before accessing the classList#225
Merged
shellscape merged 1 commit intoshellscape:masterfrom Feb 1, 2022
Merged
make sure wrapper is found before accessing the classList#225shellscape merged 1 commit intoshellscape:masterfrom
shellscape merged 1 commit intoshellscape:masterfrom
Conversation
When used with https://github.com/pmmmwh/react-refresh-webpack-plugin this error shows up during incremental builds. ```Cannot read property 'classList' of null```
Owner
|
Incremental builds wasn't something we had in mind when the plugin was initially developed. What effect does |
Contributor
Author
|
Sorry this was a little rushed, I'll try to come up with a reliable repro and some more explanation tomorrow. 👍 |
Contributor
Author
|
we have actually disabled this feature because it wasn't really supposed to work together with If you don't want this change you can close this PR 👍 |
Owner
|
I'm happy to accommodate needs here. When you say disabled, do you mean you've commented it out or added an option to disable it? |
Owner
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When used with https://github.com/pmmmwh/react-refresh-webpack-plugin this error shows up during incremental builds.
Cannot read property 'classList' of nullThis PR contains:
Breaking Changes?
If yes, please describe the breakage.
Please Describe Your Changes
I've added a check for wrapper and if it's null, it won't try to access
classList