Allow user to override publicPath setting.#230
Merged
shellscape merged 3 commits intoshellscape:masterfrom Feb 1, 2022
Merged
Conversation
This allows users to use Webpack's `auto` option for publicPath and still set a public path for the dev server.
Owner
|
I'll consider this PR once tests and documentation have been added. |
Contributor
Author
|
@shellscape docs and tests have been added. |
Owner
|
👍 I'll be giving open source some love early next week. |
Contributor
Author
|
@shellscape just following up. Any change this can get reviewed? |
Owner
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
If yes, please describe the breakage.
Please Describe Your Changes
This allows users to use Webpack's
autooption for publicPath and still set a public path for the dev server.