fix: strip accept header when using history-api-fallback#98
Merged
shellscape merged 1 commit intomasterfrom Jan 28, 2019
Merged
fix: strip accept header when using history-api-fallback#98shellscape merged 1 commit intomasterfrom
shellscape merged 1 commit intomasterfrom
Conversation
matheus1lva
approved these changes
Jan 28, 2019
bebraw
approved these changes
Jan 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
If yes, please describe the breakage.
Please Describe Your Changes
Fixes #94. When using Firefox with the
historyFallbackoption (connect-history-api-fallback), the/wpsWebSocket path is incorrectly given anAcceptheader, which makes the middleware think it's a directory index. The added middleware strips that header in that event, preventing the error, only when thehistoryFallbackoption is used.