docs(recipes): add ssr recipe [fixes #54]#99
Merged
shellscape merged 1 commit intoshellscape:masterfrom Jan 29, 2019
Merged
Conversation
smashercosmo
force-pushed
the
react-ssr
branch
from
4b993b2 to
24ef8a3
Compare
matheus1lva
reviewed
Jan 28, 2019
shellscape
approved these changes
Jan 28, 2019
Owner
shellscape
left a comment
shellscape
left a comment
There was a problem hiding this comment.
🎉 Thanks so much for doing this. Looks good to me, though I am no React expert. I will let the others chime in before merging.
Contributor
Author
|
TODO:
|
Owner
If you have the time, please open a new feature issue, and we can work on making that happen! |
matheus1lva
approved these changes
Jan 28, 2019
Collaborator
matheus1lva
left a comment
matheus1lva
left a comment
There was a problem hiding this comment.
LGTM too, and thank you for the effort!
@sibelius can you double check? You have more experience on SSR i guess.
Owner
|
OK @sibelius has given us the thumbs up offline. thanks @smashercosmo |
Contributor
Author
|
Awesome) Thx for amazing tool. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
Please Describe Your Changes
SSR example added [fixes #54]