Merged
Conversation
natsteinmetz
requested changes
Jan 12, 2020
scprojects/models.py
Outdated
| # Create your models here. | ||
|
|
||
|
|
||
| class Tag(models.Model): |
Member
There was a problem hiding this comment.
We said we'd use an external tag library, so I would not create this model here. (#6 Add tag library)
Contributor
Author
There was a problem hiding this comment.
Yes, I remember that. This is intended to be a placeholder for the future Tag library. I am assuming it will be a Django Model as well?
Contributor
Author
There was a problem hiding this comment.
I saw your other comment. Deleted the model.
scprojects/models.py
Outdated
| looking_for = models.TextField() | ||
| created = models.DateTimeField(auto_now_add=True) | ||
| updated = models.DateTimeField(auto_now=True) | ||
| tech_stack = models.ManyToManyField(Tag) |
Member
There was a problem hiding this comment.
We'd add this later, once we have integrated a tag library. So I'd remove it for now, together with the tag model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge BLOCKED - needs #9 to be merged first.