Skip to content

Added cordova iOS 4+ support#23

Merged
shi11 merged 4 commits intoshi11:masterfrom
jcesarmobile:master
Apr 15, 2016
Merged

Added cordova iOS 4+ support#23
shi11 merged 4 commits intoshi11:masterfrom
jcesarmobile:master

Conversation

@jcesarmobile
Copy link
Contributor

Added cordova iOS 4+ support.
Moved most parts of MainViewController.m to the plugin class so the
plugin user doesn’t have to add them.
Removed the RemoteControls singleton and used the NSNotificationCenter
to pass the event to the RemoteControls class.

Added cordova iOS 4 support.
Moved most parts of MainViewController.m to the plugin class so the
plugin user doesn’t have to add them.
Removed the RemoteControls singleton and used the NSNotificationCenter
to pass the event to the RemoteControls class.
@jcesarmobile jcesarmobile mentioned this pull request Mar 4, 2016
Added a MainViewController category to avoid the manual step of adding
remoteControlReceivedWithEvent method
Removed info tag from plugin.xml as manual modifications are no longer
necessary
@DahliaWitt
Copy link

Pull works great! It fixed iOS 9 for me and removed the need to modify other files. I would suggest adding it to npm using the new plugin structure (like cordova-plugin-remotecontrols).

@fenta23
Copy link

fenta23 commented Mar 31, 2016

Thx for working on this cordova ios4+ thing. It works again.
Currently im looking for the prev/next Buttons in control-center? How do i show them?

Thx, Micha.

@DahliaWitt
Copy link

They automatically show for me, you might have to run on a physical device. @fenta23

@shi11
Copy link
Owner

shi11 commented Mar 31, 2016

Hi @jcesarmobile - I'm sorry for my delay for trying out your PR. Can't wait to give it a go and Merge it. Thanks for picking up the ball and running with it! Can't wait.

@fenta23
Copy link

fenta23 commented Apr 4, 2016

@DrakeWitt: no, they are not there... just the play/pausebutton
I would like to add listeners for those buttons, so i can skip to the next track.
img_4508

@kylesziv
Copy link

Can this be merged in?

@DahliaWitt
Copy link

This repo seams dead @kylesziv. In the mean time you can do cordova plugin add https://github.com/jcesarmobile/RemoteControls

@shi11
Copy link
Owner

shi11 commented Apr 15, 2016

It's not dead, big apologies, I'm testing this update now and will merge it this evening. I'm open to adding collaborators so that I'm not the broken the link.

@shi11 shi11 merged commit d5d2796 into shi11:master Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants