[feat][cpp] Consumer support batch receive messages. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
### Motivation
Currently, the `docker-*.sh` are using the incorrect project root path. Need to fix thems.
### Modifications
* Fix the incorrect path
We need to add `git config --global --add safe.directory /pulsar-client-cpp` to the `docker-test.sh` otherwise it will throw:
```
fatal: unsafe repository ('/pulsar-client-cpp' is owned by someone else)
To add an exception for this directory, call:
git config --global --add safe.directory /pulsar-client-cpp
```
This started appearing with the release of the Git 2.35.2 security update which fixes vulnerabilities described [here](https://github.blog/2022-04-12-git-security-vulnerability-announced/). [FYI](https://stackoverflow.com/questions/71901632/fatal-error-unsafe-repository-home-repon-is-owned-by-someone-else)
* Add required for pr validation * fix
* Link to OpenSSL statically when LINK_STATIC is ON ### Motivation See discussions here: apache#28 (comment) The original purpose to not include static OpenSSL library in `libpulsarwithnossl.so` and `libpulsarwithdeps.a` is apache/pulsar#6458. However, the ABI compatibility of OpenSSL is not good. If the Pulsar C++ library links dynamically to OpenSSL and the user only changes the OpenSSL dynamic library, some symbols might not be found. ### Modifications Use `LINK_STATIC` option to determine whether to link to OpenSSL library statically. After that, there are only 3 libraries generated when `LINK_STATIC` is ON. - `libpulsar.so`: the dynamic pulsar-client-cpp library. - `libpulsar.a`: the static pulsar-client-cpp library. When it's used, users must link to all 3rd party dependencies (OpenSSL, curl, etc.) - `libpulsarwithdeps.a`: the static pulsar-client-cpp library. * Remove unnecessary code * Remove libpulsarnossl.so build
shibd
pushed a commit
that referenced
this pull request
Feb 18, 2024
…sar (apache#395) ### Motivation Pulsar 3.1.2 introduces a regression that makes two tests fail: - AuthPluginTest.testTlsDetectPulsarSslWithInvalidBroker (try #1) - AuthPluginTest.testTlsDetectHttpsWithInvalidBroker (try #1) ### Modifications Pin the Pulsar version to 3.1.1 until there is a new Pulsar release that fixes the regression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.