Skip to content

Comments

feat: improve regex#117

Open
victorbiga wants to merge 4 commits intoshift:masterfrom
victorbiga:feat/trigger
Open

feat: improve regex#117
victorbiga wants to merge 4 commits intoshift:masterfrom
victorbiga:feat/trigger

Conversation

@victorbiga
Copy link

No description provided.

@victorbiga victorbiga changed the title feat: trigger feat: improve regex Aug 10, 2023
@griseau
Copy link

griseau commented Aug 16, 2023

@shift any chance you could review it ? It would help us not to maintain a fork 🙈

@victorbiga
Copy link
Author

@shift not sure why the build failed, does not seem to this PR related. Any chance to have a look pls ?

@burnjake
Copy link
Contributor

@shift Opened a PR to fix the version issues, would be great for a review please 🙏 #118

@victorbiga
Copy link
Author

victorbiga commented Sep 4, 2023

@shift #118 now merged, would need approval to run GH Actions once again on this PR to fix missing regex on some domains.

@adamdecaf
Copy link
Collaborator

Do you have a testable response to add which verifies this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants