Add Kubernetes deployment example#23
Merged
adamdecaf merged 2 commits intoshift:masterfrom Jan 1, 2019
Merged
Conversation
Collaborator
|
Could 76eb0b4 be rebased out of this PR? I'm not sure why it was included. There's a build error with that commit anyway: https://travis-ci.org/shift/domain_exporter/jobs/474077816#L583 |
adamdecaf
reviewed
Jan 1, 2019
contrib/k8s-domain-exporter.yaml
Outdated
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: config |
Collaborator
There was a problem hiding this comment.
I'd name this domain-exporter instead of "config" to not overlap with another ConfigMap.
Contributor
Author
|
@adamdecaf done. Do you want a separate PR with the fix for the build error? |
Collaborator
|
Yea please! That error looks to be related to updated dependencies? |
Contributor
Author
|
Yes it is. Seems related to this issue: prometheus/common#136. I'll read a bit more and send a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.