Attributes code inconsistency

[guestisp]

Actually, attribute code is sanitized with URLRewrite::format() method that will remove any chars other than A-Z, 0-9 and "-"

This creates two bugs:

• any mandatory attributes added to a product can't be saved. ShineISP doesn't detect that attribute value if attribute code has "-" in it's name. The same attribute without "-" in code is saved properly
• ISPConfig module needs some attributes with "_" in it's code. (for example: "ssh_chroot"). Is not possible to save the needed attribute code because shineisp will remove the "-" from it's name and ispconfig doesn't detect it anymore.

I think that these 2 bugs are related.

[shinesoftware]

The problem has been solved with the commit baf7b3c

Here below the sample:

[guestisp]

This doesn't fix both issue but only the latter.
We did the same change yesterday and now attribute code is saved properly, but if you set that attribute as mandatory, you will not be able to save a product with that attribute set.
This because the attributes form in product configuration will convert attribute code with only letters, like this: ssh_root => sshroot and shineisp will detect an empty value for "ssh_root" (is looking for "ssh_root" instead "sshroot" ad obviously is empty)

[shinesoftware]

As shown in the screenshots posted I can save the code with the underscore. have you tried to update your shineisp code ?

[guestisp]

We did the same change yesterday.
I'm talking about a different issue. Please try to set that
attribute as mandatory and then try to save a product that
has that attribute. You will not be able to do this, because
the form field will be named "sshroot"

You have changed just the the sanitizer used when saving the
attribute, not when creating the product form.

On 10/04/2013 09:17, Shine Software wrote:

As shown in the screenshots posted I can save the code with the
underscore. have you tried to update your shineisp code ?

—
Reply to this email directly or view it on GitHub
#16 (comment).

Corbelli Alessandro
GUEST s.r.l. - CTO
Viale Giulio Cesare 25/A
47838 Riccione (RN)

[shinesoftware]

look this screenshot.

[guestisp]

This is from your demo with a mandatory attribute with dash (-) in it's code

Could you please point me to the commit that fix this?
It isn't the new formatter function because we have the same and is
still not fixed on product page.

On 10/04/2013 09:29, Shine Software wrote:

look this screenshot.

Schermata 04-2456393 alle 09 28 47
https://f.cloud.github.com/assets/1553035/360921/6991240a-a1b0-11e2-85a9-a8d1407f17a0.jpg

—
Reply to this email directly or view it on GitHub
#16 (comment).

Corbelli Alessandro
GUEST s.r.l. - CTO
Viale Giulio Cesare 25/A
47838 Riccione (RN)

[shinesoftware]

Demo updated, try to check it out now.
By the way look this comment #16 (comment)