Merged
Conversation
nodchip
reviewed
Mar 15, 2024
| if not root: | ||
| return False | ||
| if not root.left and not root.right: | ||
| if root.val == targetSum: |
There was a problem hiding this comment.
return root.val == targetSum としたほうが、 root.val != targetSum だった場合の無駄な処理が省けて良いと思います。
Owner
Author
There was a problem hiding this comment.
おっしゃるとおり葉ノードの先まで調べようとして無駄ですね。
hayashi-ay
reviewed
Mar 16, 2024
| def hasPathSum(self, root: Optional[TreeNode], targetSum: int) -> bool: | ||
| node_sum_stack = [(root, 0)] | ||
| while node_sum_stack: | ||
| node, path_sum = node_sum_stack.pop() |
There was a problem hiding this comment.
L18とL21でpath_sumの意味が変わっているかなと思いました。それぞれprev_path_sum, current_path_sumとかはどうでしょうか？
Owner
Author
There was a problem hiding this comment.
中身が変わっているので、混乱のもとになりますね。
提案していただいた変数を使ったほうが分かりやすくなると思いました。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題
https://leetcode.com/problems/path-sum/