Merged
Conversation
nodchip
reviewed
Apr 19, 2024
| """ | ||
| Do not return anything, modify nums in-place instead. | ||
| """ | ||
| num_zero = 0 |
| for i in range(len(nums)): | ||
| if nums[i] == 0: | ||
| continue | ||
| nums[last_fixed_index + 1], nums[i] = nums[i], nums[last_fixed_index + 1] |
There was a problem hiding this comment.
スワップせず、 nums[last_fixed_index + 1] = nums[i] とし、残った部分を 0 で埋めても良いと思います。
last_fixed_index = 0 から始めると、 + 1 が不要になると思います。この場合、変数名を変えるとよいと思います。
Owner
Author
There was a problem hiding this comment.
変数名をnon_zeros_lengthとしてみました。
swapだと残りの部分が0になっていることを少し考えないといけない気がしたので、最後に0埋めする方が読みやすいと思いました。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題
https://leetcode.com/problems/move-zeroes/