Skip to content

SHIP-0040: Support RuntimeClass in Builds#263

Merged
adambkaplan merged 2 commits intoshipwright-io:mainfrom
adambkaplan:ship-build-runtime-class
Dec 12, 2025
Merged

SHIP-0040: Support RuntimeClass in Builds#263
adambkaplan merged 2 commits intoshipwright-io:mainfrom
adambkaplan:ship-build-runtime-class

Conversation

@adambkaplan
Copy link
Member

Changes

Proposal to specify the Kubernetes Runtime Class in build pods. This is a direct follow up to SHIP-0039 that refines our ability to schedule and execute build pods.

Support for Kubernetes User Namespaces is also floated as an option to include in the scope, which would fit a broader theme of improving build security thorugh multiple layers of system isolation. The SHIP is thus marked as "provisional" to foster discussion.

/kind feature

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

Proposal to specify the Kubernetes Runtime Class in build pods. This is
a direct follow up to SHIP-0039 that refines our ability to schedule
and execute build pods.

Support for Kubernetes User Namespaces is also floated as an option to
include in the scope, which would fit a broader theme of improving
build security thorugh multiple layers of system isolation. The SHIP is
thus marked as "provisional" to foster discussion.

Signed-off-by: Adam Kaplan <adam.kaplan@redhat.com>
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 25, 2025
@openshift-ci openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 25, 2025
- Kubernetes user namespaces are out of scope, can be considered in a
  follow-up feature request.
- Removed requirement to fail fast if the pod schedule settings
  conflict with runtime class schedule settings.

Signed-off-by: Adam Kaplan <adam.kaplan@redhat.com>
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Apr 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2025
@adambkaplan
Copy link
Member Author

Invoking "lazy consensus rule" per our governance rules. If there are no substantive objections, this proposal will be accepted as-is at the next community meeting (2025-12-01).

@adambkaplan adambkaplan merged commit 5fd22b5 into shipwright-io:main Dec 12, 2025
1 of 2 checks passed
@github-project-automation github-project-automation bot moved this to Done in Issues Dec 12, 2025
@adambkaplan
Copy link
Member Author

Approving by lazy consensus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants