process: implement NumFDs for Windows#1454
Conversation
This PR implements the `NumFDs` method for Windows by borrowing the system info query from `OpenFiles` and using it to count any Handles belonging to the process. Signed-off-by: braydonk <braydonk@google.com>
|
Thank you for your PR. It works on my Windows 10, at least return some values. However, after some searching, I found GetProcessHandleCount. With my knowledge I do not know which is better than your PR. Could you please provide us with some URLs or other references about this PR? Thank you so much! |
|
Hi @shirou thanks for taking a look! I think you're right, since this PR I've figured out a lot better ways to get this information. In this library in particular, I believe I can make that change. In the accompanying issue #1455 I asked a question about the naming for this API; the name |
|
And we can not change the name because of compatibility. |
This PR implements the
NumFDsmethod for Windows by borrowing the system info query fromOpenFilesand using it to count any Handles belonging to the process.