chore: enable hexLiteral rule from go-critic#1890
Open
mmorel-35 wants to merge 1 commit intoshirou:masterfrom
Open
chore: enable hexLiteral rule from go-critic#1890mmorel-35 wants to merge 1 commit intoshirou:masterfrom
mmorel-35 wants to merge 1 commit intoshirou:masterfrom
Conversation
Contributor
|
Please consider enabling time-date from revive before that so you can spot the one with time date formatting issues first |
mmorel-35
force-pushed
the
gocritic/hexLiteral
branch
from
fcf0ad1 to
ccc4da5
Compare
mmorel-35
force-pushed
the
gocritic/hexLiteral
branch
from
ccc4da5 to
8216e81
Compare
Contributor
Author
Alright, I opened #1891 |
mmorel-35
force-pushed
the
gocritic/hexLiteral
branch
from
8216e81 to
903be85
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
gocritic/hexLiteral
branch
from
903be85 to
58edf40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable hexLiteral rule from go-critic