feat: Add SystemCalls and Interrupts support for AIX load metrics#1981
Open
Dylan-M wants to merge 2 commits intoshirou:masterfrom
Open
feat: Add SystemCalls and Interrupts support for AIX load metrics#1981Dylan-M wants to merge 2 commits intoshirou:masterfrom
Dylan-M wants to merge 2 commits intoshirou:masterfrom
Conversation
4 tasks
c39a999 to
7ec4780
Compare
7ec4780 to
e610fdf
Compare
e610fdf to
e058adb
Compare
e058adb to
34f7dd9
Compare
34f7dd9 to
b9d2e44
Compare
b9d2e44 to
a8f7194
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for
SystemCalls()andInterrupts()functions for AIX platform to retrieve system calls and interrupt counts since boot.Part 3 of splitting #1969: load package
Depends on #1979 #1980
Changes
SystemCalls()andInterrupts()functions toload_aix.gothat delegate to context-aware implementationsSystemCallsWithContext()andInterruptsWithContext()inload_aix_nocgo.gousing vmstat commandparseVmstatLine()helper function to parse vmstat output and extract context switches, interrupts, and syscallsgetVmstatMetrics()helper function for shared metric extraction logictestInvokerandgetInvoker()for better testabilityAvgWithContext()to use the newgetInvoker()abstractionMiscWithContext()to properly parse AIX process states (A, I, W, T, Z) and populate context switches from vmstatTesting
Changes have been validated with gofmt and golangci-lint.